Cherry pick chainlink PRs
#1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: refactor MockCCIPRouter to support EVMExtraArgsV2 * chore: commit changeset * CCIP-4288 add changeset
* adds OZ AccessControl support to the registry module * [Bot] Update changeset file with jira issues * fix snap * update version --------- Co-Authored-By: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
RensR
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
forge-std v1.9.4 ran `make snapshot-all`
…actkit/ccip into cherry-pick-contracts
RayXpub
reviewed
Nov 28, 2024
| } | ||
|
|
||
| s_owner = newOwner; | ||
| if (pendingOwner != address(0)) { |
There was a problem hiding this comment.
q: is this path tested? I don't see a test for it
RayXpub
reviewed
Nov 28, 2024
|
|
||
| s_ownable2Step.transferOwnership(STRANGER); | ||
|
|
||
| assertTrue(STRANGER != s_ownable2Step.owner()); |
There was a problem hiding this comment.
nit: we should check that pendingOwner == STRANGER
RayXpub
reviewed
Nov 28, 2024
| assertTrue(STRANGER != s_ownable2Step.owner()); | ||
|
|
||
| vm.startPrank(STRANGER); | ||
| s_ownable2Step.acceptOwnership(); |
There was a problem hiding this comment.
nit: missing checks:
- New owner updated
- Pending owner reset
- Event
RayXpub
approved these changes
Nov 28, 2024
0xsuryansh
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings three changes into the ccip repo
chainlink